四川:梳理81个突出问题 开展八项规定精神"回头看"
Bug #62976 reported by
Colin Watson
This bug affects 7 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
High
|
Unassigned | ||
| pepess |
Invalid
|
Undecided
|
Unassigned | ||
Bug Description
百度 五是抓好生态文明建设。
It's still possible for two uploads with the same package name and version to land in the unapproved queue; furthermore it is then possible to simultaneously accept both of them. Neither of these should be allowed.
OOPS-2018FTPMASTERPUBLISH1
Revision history for this message
| Celso Providelo (cprov) wrote | #1 |
| Changed in soyuz: | |
| assignee: | nobody → cprov |
| importance: | Undecided → High |
| status: | Unconfirmed → Confirmed |
Revision history for this message
| Colin Watson (cjwatson) wrote | #2 |
Revision history for this message
| Celso Providelo (cprov) wrote | #3 |
Revision history for this message
| Celso Providelo (cprov) wrote | #4 |
| Changed in soyuz: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Celso Providelo (cprov) wrote | #5 |
| Changed in soyuz: | |
| assignee: | cprov → nobody |
| status: | In Progress → Confirmed |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #7 |
Revision history for this message
| William Grant (wgrant) wrote | #8 |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #9 |
| Changed in launchpad: | |
| importance: | High → Critical |
| tags: | added: oops |
| description: | updated |
Revision history for this message
| Julian Edwards (julian-edwards) wrote Re: [Bug 62976] Re: Soyuz should not allow duplicated packages in NEW/UNAPPROVED queue | #10 |
| Changed in launchpad: | |
| status: | Triaged → New |
| status: | New → Incomplete |
| status: | Incomplete → Opinion |
| status: | Opinion → Invalid |
| status: | Invalid → Confirmed |
| status: | Confirmed → In Progress |
| status: | In Progress → Fix Committed |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu: | |
| status: | New → Incomplete |
| status: | Incomplete → Opinion |
| status: | Opinion → Invalid |
| status: | Invalid → Confirmed |
| status: | Confirmed → In Progress |
| status: | In Progress → Fix Committed |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu: | |
| status: | Fix Released → New |
| Changed in launchpad: | |
| status: | Fix Released → Triaged |
| no longer affects: | ubuntu |
| Changed in launchpad: | |
| status: | Triaged → Confirmed |
| Changed in launchpad: | |
| status: | Confirmed → Triaged |
| Changed in launchpad: | |
| status: | Triaged → New |
| affects: | launchpad → google-launchpad-migrator |
| Changed in google-launchpad-migrator: | |
| assignee: | nobody → dexter dimaculangan (dexterjohn2011) |
| status: | New → Confirmed |
| affects: | google-launchpad-migrator → launchpad |
| Changed in launchpad: | |
| status: | Confirmed → Triaged |
| assignee: | dexter dimaculangan (dexterjohn2011) → nobody |
Revision history for this message
| Colin Watson (cjwatson) wrote | #11 |
| information type: | Public → Public Security |
| information type: | Public Security → Public |
| Changed in launchpad: | |
| status: | Triaged → Fix Released |
| Changed in launchpad: | |
| status: | Fix Released → Triaged |
| Changed in launchpad: | |
| status: | Triaged → Fix Released |
| Changed in launchpad: | |
| status: | Fix Released → Triaged |
| no longer affects: | ubuntu |
| Changed in launchpad: | |
| status: | Triaged → Confirmed |
| Changed in launchpad: | |
| status: | Confirmed → Triaged |
| Changed in launchpad: | |
| assignee: | nobody → Anthony Ochoa (anthony1985) |
| no longer affects: | ubuntu |
| Changed in launchpad: | |
| assignee: | Anthony Ochoa (anthony1985) → nobody |
| Changed in launchpad: | |
| assignee: | nobody → Wendell Nicolas (dentubuntu) |
| Changed in launchpad: | |
| assignee: | Wendell Nicolas (dentubuntu) → nobody |
| Changed in launchpad: | |
| assignee: | nobody → nguyen thanh anh vu (vunguyen67) |
| assignee: | nguyen thanh anh vu (vunguyen67) → nobody |
| Changed in launchpad: | |
| status: | Triaged → Fix Released |
| Changed in launchpad: | |
| status: | Fix Released → Triaged |
| Changed in launchpad: | |
| assignee: | nobody → kirill (kirill-yalta) |
| status: | Triaged → Confirmed |
| no longer affects: | ubuntu |
| Changed in launchpad: | |
| assignee: | kirill (kirill-yalta) → nobody |
| status: | Confirmed → Triaged |
| Changed in launchpad: | |
| assignee: | nobody → Jemiter Mwale (jemitermwale) |
| Changed in pepess: | |
| status: | New → Invalid |
| Changed in launchpad: | |
| assignee: | Jemiter Mwale (jemitermwale) → nobody |
| information type: | Public → Private |
| information type: | Private → Public |
| Changed in launchpad: | |
| importance: | Critical → High |
Revision history for this message
| Colin Watson (cjwatson) wrote | #12 |
To post a comment you must log in.
That's unfortunatelly right ...
As we discussed on IRC, the fact we allow dups in NEW & UNAPPROVED is annoying, but the fix will require a fix in nascentupload workflow which we are trying to keep quiet until we land ArchiveRework (because the code will need redesign for PPA anyway).
My suggestion is to workaround this situation with two fixes:
* Materialize the state updates for each item inside the queue action batch, so the already existent lookup will find the just-modified candidate (this is a bug in previous implementation, one line fix)
* Fix queue "fetch" action to use ID as a tie-breaker when writing dupes to disk, so foo_1.0.dsc will become foo_1.0.dsc-<ID> if it is already in disk.
Kamion, would you be satisfied (for a while) with this alternative plan ?